Skip to content

NO-ISSUE: Update dev go image#2735

Open
pablintino wants to merge 1 commit intoopenshift:masterfrom
pablintino:update-dev-runtime-go-image
Open

NO-ISSUE: Update dev go image#2735
pablintino wants to merge 1 commit intoopenshift:masterfrom
pablintino:update-dev-runtime-go-image

Conversation

@pablintino
Copy link
Contributor

Since go.mod was updated to use Go 1.25 the 1.24 builder image we were using is no longer valid.
The go version bump updated all the required CI images but left the dev one in the Makefile with the previous content.

Since go.mod was updated to use Go 1.25 the 1.24 builder image we were
using is no longer valid.
The go version bump updated all the required CI images but left the dev
one in the Makefile with the previous content.

Signed-off-by: Pablo Rodriguez Nava <git@amail.pablintino.com>
@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 3, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2026

Hello @pablintino! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci-robot
Copy link

@pablintino: This pull request explicitly references no jira issue.

Details

In response to this:

Since go.mod was updated to use Go 1.25 the 1.24 builder image we were using is no longer valid.
The go version bump updated all the required CI images but left the dev one in the Makefile with the previous content.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@qodo-code-review
Copy link

Review Summary by Qodo

Update dev Go runtime image to 1.25

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Update dev runtime Go image from 1.24 to 1.25
• Align Makefile with go.mod Go version requirement
• Update OpenShift release image to version 4.22
Diagram
flowchart LR
  A["Go 1.24 image<br/>rhel-9-release-golang-1.24<br/>openshift-4.20"] -- "update to" --> B["Go 1.25 image<br/>rhel-9-release-golang-1.25<br/>openshift-4.22"]
Loading

Grey Divider

File Changes

1. Makefile ⚙️ Configuration changes +1/-1

Update dev Go image to 1.25

• Updated RUNTIME_IMAGE_NAME variable from Go 1.24 to Go 1.25
• Changed OpenShift release version from 4.20 to 4.22
• Aligns dev environment with go.mod Go version requirement

Makefile


Grey Divider

Qodo Logo

@qodo-code-review
Copy link

qodo-code-review bot commented Mar 3, 2026

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider


Remediation recommended

1. Unpinned dev builder image 🐞 Bug ⛯ Reliability
Description
The updated RUNTIME_IMAGE_NAME uses a mutable tag (no digest pin). If the registry tag is ever
re-pushed, container-based verify/generate runs can become non-reproducible and unexpectedly change
behavior across developers/machines.
Code

Makefile[7]

+RUNTIME_IMAGE_NAME ?= registry.ci.openshift.org/openshift/release:rhel-9-release-golang-1.25-openshift-4.22
Evidence
The Makefile sets RUNTIME_IMAGE_NAME to a tag (not a digest) and uses it directly to run
verification and generation in a container, so any tag mutation changes the environment used by
these workflows.

Makefile[6-8]
Makefile[172-176]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`RUNTIME_IMAGE_NAME` is set to a mutable tag. This makes `make verify-with-container` and `make generate-with-container` non-reproducible if the tag content changes over time.

### Issue Context
The Makefile runs verification/generation inside the image referenced by `$(RUNTIME_IMAGE_NAME)`, so the exact image content matters for deterministic results.

### Fix Focus Areas
- Makefile[6-8]
- Makefile[172-176]

### Suggested change
- Update `RUNTIME_IMAGE_NAME` to include a digest, e.g.:
 - `registry.ci.openshift.org/openshift/release:rhel-9-release-golang-1.25-openshift-4.22@sha256:&lt;digest&gt;`
- Optionally keep the tag in a separate variable and append `@$(RUNTIME_IMAGE_DIGEST)` when set.
- Add a short comment documenting how to obtain the digest (e.g., via `skopeo inspect docker://...`).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 3, 2026
@openshift-ci openshift-ci bot requested review from JoelSpeed and everettraven March 3, 2026 10:01
@coderabbitai
Copy link

coderabbitai bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between dcac36b and eb925b2.

📒 Files selected for processing (1)
  • Makefile

📝 Walkthrough

Walkthrough

The RUNTIME_IMAGE_NAME variable in the Makefile was updated to reference a newer base image. The change updates the Go version from 1.24 to 1.25 and the OpenShift release version from 4.20 to 4.22. The updated image tag is used as the default container runtime image during the build process.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: updating the Go image in the Makefile from 1.24 to 1.25 to match the go.mod update.
Description check ✅ Passed The description is directly related to the changeset, explaining why the Makefile runtime image needed to be updated due to the Go version bump.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2026
@openshift-ci-robot
Copy link

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2026
@JoelSpeed
Copy link
Contributor

/retest
/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 4, 2026
@openshift-ci-robot
Copy link

@JoelSpeed: This PR has been marked as verified by CI.

Details

In response to this:

/retest
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2026

@pablintino: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-techpreview-1of2 eb925b2 link true /test e2e-aws-serial-techpreview-1of2
ci/prow/e2e-aws-serial-techpreview-2of2 eb925b2 link true /test e2e-aws-serial-techpreview-2of2
ci/prow/e2e-aws-ovn-hypershift eb925b2 link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-ovn-techpreview eb925b2 link true /test e2e-aws-ovn-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants