Conversation
Since go.mod was updated to use Go 1.25 the 1.24 builder image we were using is no longer valid. The go version bump updated all the required CI images but left the dev one in the Makefile with the previous content. Signed-off-by: Pablo Rodriguez Nava <git@amail.pablintino.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
Hello @pablintino! Some important instructions when contributing to openshift/api: |
|
@pablintino: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Review Summary by QodoUpdate dev Go runtime image to 1.25
WalkthroughsDescription• Update dev runtime Go image from 1.24 to 1.25 • Align Makefile with go.mod Go version requirement • Update OpenShift release image to version 4.22 Diagramflowchart LR
A["Go 1.24 image<br/>rhel-9-release-golang-1.24<br/>openshift-4.20"] -- "update to" --> B["Go 1.25 image<br/>rhel-9-release-golang-1.25<br/>openshift-4.22"]
File Changes1. Makefile
|
Code Review by Qodo
1. Unpinned dev builder image
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to data retention organization setting 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
|
/lgtm |
|
Scheduling tests matching the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@JoelSpeed: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@pablintino: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Since go.mod was updated to use Go 1.25 the 1.24 builder image we were using is no longer valid.
The go version bump updated all the required CI images but left the dev one in the Makefile with the previous content.